Skip to content

Conversation

mshvarts
Copy link

@mshvarts mshvarts commented Oct 3, 2025

Issue: #3722

Not gonna say I didn't use GPT, which I did, but it worked for me as you can see:

image

I already did this in my repo and built it locally.
I just took the time to make this pull request out of care for others people having this problem and to contribute to this wonderful plugin.

PS: I tried running tests to make sure it doesn't break anything but they were already failing on my machine even before i made any changes. (So merge at your own risk)

@mshvarts
Copy link
Author

mshvarts commented Oct 6, 2025

Just saw few tests are failed, I haven't had time to look closely, since I haven't figured out how to run a single test instead of the whole suite, but I think it means few tests need to be changed and not due to an issue in the code.

@gvwilson gvwilson added feature something new community community contribution P2 considered for next cycle labels Oct 7, 2025
@gvwilson
Copy link
Contributor

gvwilson commented Oct 7, 2025

Thanks for the PR @mshvarts - can you please update the tests as well? Once that's done I'll see if I can find a reviewer. Thanks - @gvwilson

@mshvarts
Copy link
Author

mshvarts commented Oct 7, 2025

Thanks for the PR @mshvarts - can you please update the tests as well? Once that's done I'll see if I can find a reviewer. Thanks - @gvwilson

Sorry I work full time and don't have time now. I can try to look into it later if you let me know how to run individual tests on my machine? Every time I tried adding flags it just ran the whole test suite instead and takes forever to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants